Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] merging eslint files #3033

Closed

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Jul 24, 2024

RHOAIENG-2534

Description

merging eslint config files

How Has This Been Tested?

Break some rules in various eslint files. It should show, and npm run test should work in root, backend, and frontend directories.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lucferbux for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

package.json Outdated Show resolved Hide resolved
@rsun19 rsun19 force-pushed the merge-eslint-configs-part-2 branch from 80cbad0 to 4a7ff20 Compare July 24, 2024 18:44
frontend/tsconfig.json Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
@rsun19 rsun19 force-pushed the merge-eslint-configs-part-2 branch from 4a7ff20 to 59ddbc9 Compare July 25, 2024 15:58
@rsun19 rsun19 changed the title merging eslint files [WIP] merging eslint files Jul 25, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 25, 2024
@rsun19 rsun19 force-pushed the merge-eslint-configs-part-2 branch from b0811d2 to 5ce6573 Compare July 26, 2024 23:45
@rsun19
Copy link
Contributor Author

rsun19 commented Jul 26, 2024

@christianvogt made requested changes. For this to work, we will need to notify people to get rid of their working directory eslint setting, since our combined eslintrc file seems to confuse the vscode eslint extension.

@rsun19 rsun19 force-pushed the merge-eslint-configs-part-2 branch from 5ce6573 to df000c5 Compare July 26, 2024 23:50
@rsun19 rsun19 changed the title [WIP] merging eslint files merging eslint files Jul 26, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jul 26, 2024
@rsun19 rsun19 force-pushed the merge-eslint-configs-part-2 branch from df000c5 to 867c8f1 Compare July 26, 2024 23:52
@rsun19 rsun19 changed the title merging eslint files [WIP] merging eslint files Jul 27, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 27, 2024
@rsun19 rsun19 closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants