Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snyk - Uncontrolled Resource Consumption ('Resource Exhaustion') #3039

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented Jul 29, 2024

Closes: RHOAIENG-10147

Description

Updated tar in backend to remove vulnerability.

How Has This Been Tested?

cd backend
npm audit

Also checked by deploying image

Test Impact

No test, just dependency upgrade.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@dpanshug
Copy link
Contributor Author

dpanshug commented Jul 29, 2024

WIP: Tests are failing

Update: Tests are passing, good to review

@dpanshug dpanshug changed the title Snyk - Uncontrolled Resource Consumption ('Resource Exhaustion') [WIP] Snyk - Uncontrolled Resource Consumption ('Resource Exhaustion') Jul 29, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 29, 2024
@dpanshug dpanshug changed the title [WIP] Snyk - Uncontrolled Resource Consumption ('Resource Exhaustion') Snyk - Uncontrolled Resource Consumption ('Resource Exhaustion') Jul 30, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jul 30, 2024
@Gkrumbach07
Copy link
Member

/lgtm
/approve

tar is updated

Copy link
Contributor

openshift-ci bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8d231fb into opendatahub-io:main Aug 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants