Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableConnectionTypes feature flag #3041

Conversation

emilys314
Copy link
Contributor

@emilys314 emilys314 commented Jul 29, 2024

https://issues.redhat.com/browse/RHOAIENG-10564

Description

Adds a new feature flag to the odhDashboardConfig for the upcoming work on the custom data connection types feature.

How Has This Been Tested?

  • Pushed the updated CRD to my personal cluster with the new flags and verified the flag being received in network requests.
  • Running the frontend and backend locally, got the new flag saw it in the browser console.
  • turned the flag to true and false to verify it switches
    Screenshot from 2024-07-29 14-45-20

Test Impact

  • no tests added, not really much to test yet? other feature flags don't have tests either

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jul 29, 2024
Copy link
Contributor

openshift-ci bot commented Jul 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@emilys314 emilys314 force-pushed the create-data-connection-types-flag branch 2 times, most recently from 8403e6a to bcf3355 Compare July 29, 2024 18:54
@emilys314 emilys314 marked this pull request as ready for review July 29, 2024 19:34
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jul 29, 2024
@emilys314 emilys314 force-pushed the create-data-connection-types-flag branch from bcf3355 to 1f0315d Compare July 29, 2024 20:34
@emilys314 emilys314 force-pushed the create-data-connection-types-flag branch from 1f0315d to e26dce1 Compare July 29, 2024 20:35
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8b1da65 into opendatahub-io:main Jul 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants