Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving testing dependencies to optional #3042

Merged

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Jul 29, 2024

RHOAIENG-10400

Description

moving test dev dependencies to optional

How Has This Been Tested?

npm run test

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from dpanshug and mturley July 29, 2024 18:43
Copy link
Contributor

@christianvogt christianvogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsun19 can we also move the following test related modules:

"@jsdevtools/coverage-istanbul-loader": "^3.0.5",
"@types/chai-subset": "^1.3.5",
"@typescript-eslint/eslint-plugin": "^7.1.1",
"@typescript-eslint/parser": "^7.1.1",
"chai-subset": "^1.6.0",
"expect": "^29.7.0",
"http-server": "^14.1.1",
"istanbul-merge": "^2.0.0",
"junit-report-merger": "^7.0.0",
"mocha-junit-reporter": "^2.2.1",
"nyc": "^15.1.0",
"serve": "^14.2.1",
"wait-on": "^7.2.0",

@rsun19
Copy link
Contributor Author

rsun19 commented Jul 31, 2024

@christianvogt made requested changes

@christianvogt
Copy link
Contributor

/lgtm
/approve

Tested locally after deleting node_modules and running a fresh npm install.
Ran junit, cypress, and local dev env successfully.

Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 45b6306 into opendatahub-io:main Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants