Fix for untrue !Deleted flag

[ashley-o0o]

Closes: RHOAIENG-8553

Description

Fixes a bug where a workbench created with a custom images shows a "! Deleted" flag when not true
Steps to reproduce this bug is in the JIRA ticket linked. Note the cluster type. I'm unable to reproduce this bug on a ROSA cluster currently.
Please reach out to me on slack if you need help testing this.

How Has This Been Tested?

npm run test. Locally on an OCP cluster

Test Impact

A jest test was added that checks if the fix fails when the image doesn't match
Before:

After:

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[christianvogt]

@lucferbux can you please review this change

[lucferbux]

Ok, with those tweaks the PR should be ready to go, it's great that the testint caught our error before integrating.

[lucferbux]

Changes look great now, I would recommend run the logic with @atheo89 and @jstourac detailed here before giving the lgtm.

I'll be out starting tomorrow, if they cannot verify it today, @mturley can you help me out here and give a lgtm?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [lucferbux]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lucferbux]

/hold

[jstourac]

Hi @lucferbux , I won't get to this today in the end, but will try to do it the first thing tomorrow. Andriana is on PTO, so she won't respond till next week, I'm afraid.

[jstourac]

I reviewed the code briefly and put two comments. Otherwise LGTM, but I'm not a typescript developer, so take this into account 🙂

Also, I tried the image on my cluster and seems that the fix works as expected.

[ashley-o0o]

/unhold

[jstourac]

/lgtm