Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use artifact downloader hook in fetching markdown html #3053

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Aug 1, 2024

https://issues.redhat.com/browse/RHOAIENG-9738

Description

Updated the useArtifactStorage function to make it more stable
Updated the manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml
Updated the compare run section to use the new hook useArtifactStorage
Updated the artifact nodes virtualization side drawer panel to use new hook useArtifactStorage

How Has This Been Tested?

Update the crd ,check if disableArtifactsAPI is false the fetch is from the DSP server
when disableArtifactsAPI is true and disableS3Endpoint is false check the fetching occurs from backend
while running locally
open -n -a /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --args --user-data-dir="/tmp/chrome_dev_test" --disable-web-security to avoid cors error

  1. Upload a pipeline with metrics
  2. Create a run with uploaded pipeline
  3. Go to compare runs and check in the markdown section, check the behaviour
    4.Go to the created run page and click on the node, from the right side panel, click on the visualization tab, check the behaviour

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1 pnaik1 force-pushed the RHOAIENG-9738 branch 2 times, most recently from 6f6cdaf to 5446aae Compare August 1, 2024 13:05
@pnaik1 pnaik1 changed the title Use artifact downloader hook in fetching markdown html [WIP] Use artifact downloader hook in fetching markdown html Aug 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Aug 5, 2024
@pnaik1
Copy link
Contributor Author

pnaik1 commented Aug 5, 2024

The PR is been blocked due to browser running into CORS issues on s3 pre-signed URL

@pnaik1 pnaik1 changed the title [WIP] Use artifact downloader hook in fetching markdown html Use artifact downloader hook in fetching markdown html Aug 8, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Aug 8, 2024
@pnaik1
Copy link
Contributor Author

pnaik1 commented Aug 8, 2024

added cypress test for compare runs,

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a live cluster, lgtm
/lgtm
Screenshot 2024-08-12 at 3 39 49 PM
Screenshot 2024-08-12 at 3 39 40 PM
Screenshot 2024-08-12 at 3 39 28 PM

@Gkrumbach07
Copy link
Member

This looks good, but why is the markdown not rendering anymore, html looks fine, but markdown is rendering as plain text @pnaik1

@pnaik1
Copy link
Contributor Author

pnaik1 commented Aug 13, 2024

@Gkrumbach07 , I see iframe renders same way the browser does
I double checked with the artifactlink which opens the new tab
its same

Screenshot 2024-08-13 at 11 24 24 AM

@Gkrumbach07
Copy link
Member

I see iframe renders same way the browser does
I double checked with the artifactlink which opens the new tab
its same

We talked about this and it is not possible right now without hitting cors to achieve this so i am approving

/approve

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9ffed3c into opendatahub-io:main Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants