-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connection type preview form generation #3056
connection type preview form generation #3056
Conversation
05f50d7
to
587e95d
Compare
587e95d
to
70b68f5
Compare
70b68f5
to
d47ef12
Compare
@emilys314 @jeff-phillips-18 rebased this PR |
Looks good to me I think |
value?: string[]; | ||
}; | ||
|
||
const DropdownFormField: React.FC<Props> = ({ field, isPreview, onChange, value }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Calling it a Dropdown but using a Select could be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. It coincides with the type. And the type name will be shown to the user as an available type.
Perhaps we should discuss the type name with us?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-10319
Description
Generates a preview form from the connection type resource and field descriptors.
Uses the existing mock which encompasses all variations of fields.
Form fields are rendered in their default states but do not react to changes so they act as read only.
Provides a drawer component to render the content preview given the connection type resource.
There are still several UX discussions on going but any changes should be minimal to incorporate.
There's also a quirk with dropdowns that is causing the drawer to scroll back to the top whenever it is opened. This can be dealt with later.
How Has This Been Tested?
Manually. Test pages.
Added unit tests.
Test Impact
Unit tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @simrandhaliw