Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection type preview form generation #3056

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Aug 1, 2024

https://issues.redhat.com/browse/RHOAIENG-10319

Description

Generates a preview form from the connection type resource and field descriptors.
Uses the existing mock which encompasses all variations of fields.

Form fields are rendered in their default states but do not react to changes so they act as read only.

Provides a drawer component to render the content preview given the connection type resource.

There are still several UX discussions on going but any changes should be minimal to incorporate.
There's also a quirk with dropdowns that is causing the drawer to scroll back to the top whenever it is opened. This can be dealt with later.

image
image
image
image
image
image
image
image
image
image

How Has This Been Tested?

Manually. Test pages.
Added unit tests.

Test Impact

Unit tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

@christianvogt
Copy link
Contributor Author

@emilys314 @jeff-phillips-18 rebased this PR

@emilys314
Copy link
Contributor

Looks good to me I think

value?: string[];
};

const DropdownFormField: React.FC<Props> = ({ field, isPreview, onChange, value }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Calling it a Dropdown but using a Select could be confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. It coincides with the type. And the type name will be shown to the user as an available type.

Perhaps we should discuss the type name with us?

@jeff-phillips-18
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 934fe4a into opendatahub-io:main Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants