-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin - Model Registry RBAC Management Projects #3057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ppadti. This is looking good! Just a few things to address.
.../__tests__/cypress/cypress/tests/mocked/modelRegistrySettings/modelRegistryPermissions.cy.ts
Outdated
Show resolved
Hide resolved
.../__tests__/cypress/cypress/tests/mocked/modelRegistrySettings/modelRegistryPermissions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/concepts/roleBinding/RoleBindingPermissionsTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/roleBinding/RoleBindingPermissionsTableRowAdd.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistrySettings/ProjectsTab/ProjectsSettingsTab.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistrySettings/ProjectsTab/ProjectsSettingsTab.tsx
Show resolved
Hide resolved
ae32937
to
2c58e64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing --- everything is working great here, I just think I may have steered you wrong in terms of code readability.
frontend/src/concepts/roleBinding/RoleBindingPermissionsTable.tsx
Outdated
Show resolved
Hide resolved
The dropdown is missing the placeholder text |
@yih-wang I have updated the screenshots above. Thanks for pointing this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! works great and reads well. Thanks for the iteration on this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gitdallas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-8632
Description
This PR aims to add projects tab under MR Permissions.
How Has This Been Tested?
In MR permission, click on Projects tab
create/ edit/ delete rolebindings for projects.
Test Impact
Added cypress tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main