Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin - Model Registry RBAC Management Projects #3057

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Aug 2, 2024

Closes: RHOAIENG-8632

Description

This PR aims to add projects tab under MR Permissions.

Screenshot from 2024-08-08 18-39-47

Screenshot from 2024-08-08 16-59-38

Screenshot from 2024-08-08 17-55-41

How Has This Been Tested?

In MR permission, click on Projects tab
create/ edit/ delete rolebindings for projects.

Test Impact

Added cypress tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ppadti. This is looking good! Just a few things to address.

@ppadti ppadti force-pushed the RHOAIENG-8632 branch 3 times, most recently from ae32937 to 2c58e64 Compare August 7, 2024 20:06
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing --- everything is working great here, I just think I may have steered you wrong in terms of code readability.

@yih-wang
Copy link

yih-wang commented Aug 8, 2024

The dropdown is missing the placeholder text Select or enter a project. It's important for users to know that they can either select from the menu items or free type a new name.

@ppadti
Copy link
Contributor Author

ppadti commented Aug 8, 2024

The dropdown is missing the placeholder text Select or enter a project. It's important for users to know that they can either select from the menu items or free type a new name.

@yih-wang I have updated the screenshots above. Thanks for pointing this out.
I have also included the revised and newly proposed text here. Please have a look.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! works great and reads well. Thanks for the iteration on this.

Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5cd9055 into opendatahub-io:main Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants