-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate connection page UI #3059
Duplicate connection page UI #3059
Conversation
Skipping CI for Draft Pull Request. |
1fdaa58
to
55b73d3
Compare
f7a8c56
to
a842c0c
Compare
a842c0c
to
9661df9
Compare
5974089
to
2ed6fd9
Compare
2ed6fd9
to
6488dca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate page looks good and works as expected @emilys314 , tested by creating a data connection and was able to duplicate it successfully.
Just a note about the empty state table under Fields, would we want to use a default empty state rather than an empty state table? According to the mocks it looks like we don't want to show the table headers if there are no fields.
Otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested locally, and ran the Cypress tests in the Cypress UI. Everything looking good on my end! One note, you'll need to squash commits before approval :) |
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
/cc @simrandhaliw |
I think this is no longer the case. based on what i was seeing in some slack convos, the PR should squash it for you now |
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypeUtils.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypeFooter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypeFooter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypeFieldsTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypeFieldsTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypeFieldsTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypeFieldsTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/CreateConnectionType/CreateConnectionTypeFieldsTableRow.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/connectionTypes/createConnectionTypeUtils.ts
Outdated
Show resolved
Hide resolved
frontend/src/concepts/connectionTypes/createConnectionTypeUtils.ts
Outdated
Show resolved
Hide resolved
frontend/src/concepts/connectionTypes/createConnectionTypeUtils.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/create/CreateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/create/CreateConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/connectionTypes/create/DuplicateConnectionTypePage.tsx
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jenny-s51 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Towards https://issues.redhat.com/browse/RHOAIENG-10314
Description
Adds the UI portion of the create / duplicate connection type page. The jira issue is for the duplicate page, but a lot of the create page is already made since it's dependent.
Error state:
How Has This Been Tested?
Manually on local. Start the front end and back end. Then go to the
/connectionTypes/create
or/connectionTypes/duplicate/<name>
routes./duplicate
requires an existing connection type. So you can go to/create
and Make one first.Test Impact
Cypress tests were added for create and duplicate pages.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main