trim cron string #3061
trim cron string #3061
Conversation
frontend/src/concepts/pipelines/content/createRun/contentSections/TriggerTypeField.tsx
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/pipelineCreateRuns.cy.ts
Outdated
Show resolved
Hide resolved
| runtime_config: { | ||
| parameters: { min_max_scaler: false, neighbors: 1, standard_scaler: 'no' }, | ||
| }, | ||
| trigger: { cron_schedule: { cron: '@every 5m' } }, |
There was a problem hiding this comment.
Where is the test for '@every 5m '
The one that contains the space?
There was a problem hiding this comment.
@diegolovison , I have created two separate case
the one with whitespace is in this line https://github.com/opendatahub-io/odh-dashboard/pull/3061/files/3d1bd4b1eb2198f3dca928339229211e5bb11cf0#diff-ff1a31b964e7adebb99b1bee1eaa6d2678fd21025df88198dd7da5ade83aa8aaR627
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: DaoDaoNoCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-9537
Description
the user can end up with an error while submitting a scheduled run because of white space to avoid this I have trim white spaces from cron string
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main