fix(ProjectList): notebook status listen and update #3070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: RHOAIENG-5084
Description
In the big "UI Refresh", it seems that the
doListen
got set to false where it shouldn't have. Previously here: d5124d2#diff-2c0ccfc2c2e7347604445b4d648b808d62e96fe6fd36c05cec54ea14bcd3d10dL46Setting it to true for the project list view fixes the issue.
It's interesting that the status is used in the projects page and the notebook page, but is updated differently. The notebook tab has
doListen={false}
and updates fine (must update at a different level instead of from the statusToggle component itself).How Has This Been Tested?
Tested that the status updates properly and doesn't continue to make network calls for the status after getting the update.
Test Impact
none
Request review criteria:
test that the toggle works properly and updates properly on both pages.
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main