Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProjectList): notebook status listen and update #3070

Conversation

gitdallas
Copy link
Contributor

closes: RHOAIENG-5084

Description

In the big "UI Refresh", it seems that the doListen got set to false where it shouldn't have. Previously here: d5124d2#diff-2c0ccfc2c2e7347604445b4d648b808d62e96fe6fd36c05cec54ea14bcd3d10dL46

Setting it to true for the project list view fixes the issue.

It's interesting that the status is used in the projects page and the notebook page, but is updated differently. The notebook tab has doListen={false} and updates fine (must update at a different level instead of from the statusToggle component itself).

How Has This Been Tested?

Tested that the status updates properly and doesn't continue to make network calls for the status after getting the update.

Test Impact

none

Request review criteria:

test that the toggle works properly and updates properly on both pages.

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 62728f1 into opendatahub-io:main Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants