Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10313/delete connection type #3083

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Aug 13, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-10313

Description

Add the table kebab and delete option to the connection types table. This code is being build off of this PR (3067)

How Has This Been Tested?

Tested locally as well as using Cypress

Test Impact

Added Cypress tests to test the delete function and kebab functionality

Screenshots

Screenshot 2024-08-14 at 1 37 37 PM Screenshot 2024-08-14 at 1 37 46 PM 6-9594-a06b7d4d4961"> Screenshot 2024-08-14 at 1 37 58 PM Screenshot 2024-08-14 at 1 38 20 PM Screenshot 2024-08-14 at 1 38 10 PM Screenshot 2024-08-14 at 1 38 32 PM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Aug 13, 2024
Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ashley-o0o ashley-o0o force-pushed the 10313/delete-connection-type branch 3 times, most recently from 3b2e32c to b79e26c Compare August 14, 2024 14:03
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Aug 14, 2024
@ashley-o0o ashley-o0o force-pushed the 10313/delete-connection-type branch 2 times, most recently from cecc1cb to ab2a676 Compare August 14, 2024 15:12
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Aug 14, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Aug 14, 2024
@ashley-o0o ashley-o0o force-pushed the 10313/delete-connection-type branch 2 times, most recently from 8c4734c to 8801aa1 Compare August 14, 2024 15:51
@ashley-o0o ashley-o0o marked this pull request as ready for review August 14, 2024 15:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Aug 14, 2024
@ashley-o0o ashley-o0o force-pushed the 10313/delete-connection-type branch 2 times, most recently from 6288382 to 1eee870 Compare August 15, 2024 14:31
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Aug 15, 2024
@ashley-o0o ashley-o0o force-pushed the 10313/delete-connection-type branch 3 times, most recently from 132dafe to a09dae3 Compare August 15, 2024 21:31
@jeff-phillips-18
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1768c96 into opendatahub-io:main Aug 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants