Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-11049 Add tracking for model serving #3111

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

pilhuhn
Copy link
Contributor

@pilhuhn pilhuhn commented Aug 21, 2024

https://issues.redhat.com/browse/RHOAIENG-11049

Description

Add Segment tracking for Model serving Deploy/Edit/Delete operations

How Has This Been Tested?

Manual testing by clicking in the UI and watching the events fired in the browser console

  • Deploy a Model in Kserve (submit / cancel cases)
  • Deploy a Model server, (submit / cancel )
  • Edit a Model server (submit /cancel)
  • Deploy a model on a model server

Those should all yield lines like the following in the browser console, when in dev-mode. The outcome property should match the action submit/cancel of the dialog.

Telemetry event triggered: Model Deployed - {"outcome":"cancel","type":"multi"} for version v2.25.0
Telemetry event triggered: Model Server Modified - {"outcome":"submit","type":"OpenVINO Model Server","size":"Small","success":true} for version v2.25.0
Telemetry event triggered: Model Server Deleted - {"outcome":"submit"} for version v2.25.0

Test Impact

Manual testing as described above

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pilhuhn pilhuhn force-pushed the RHOAIENG-11049 branch 2 times, most recently from 8647eab to 49dad49 Compare August 21, 2024 15:38
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.15%. Comparing base (af2099a) to head (23a224e).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...elServing/screens/global/InferenceServiceTable.tsx 0.00% 4 Missing ⚠️
...ects/KServeSection/KServeInferenceServiceTable.tsx 0.00% 2 Missing ⚠️
.../ServingRuntimeModal/ManageServingRuntimeModal.tsx 91.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
+ Coverage   80.87%   85.15%   +4.27%     
==========================================
  Files        1239     1251      +12     
  Lines       26893    27415     +522     
  Branches     7041     7274     +233     
==========================================
+ Hits        21750    23345    +1595     
+ Misses       5143     4070    -1073     
Files with missing lines Coverage Δ
.../projects/ModelMeshSection/ServingRuntimeTable.tsx 86.95% <100.00%> (+3.62%) ⬆️
...screens/projects/kServeModal/ManageKServeModal.tsx 97.76% <100.00%> (+5.13%) ⬆️
.../ServingRuntimeModal/ManageServingRuntimeModal.tsx 93.15% <91.66%> (+4.44%) ⬆️
...ects/KServeSection/KServeInferenceServiceTable.tsx 80.00% <0.00%> (+1.21%) ⬆️
...elServing/screens/global/InferenceServiceTable.tsx 71.42% <0.00%> (-1.65%) ⬇️

... and 631 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2099a...23a224e. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 191aebc into opendatahub-io:main Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants