-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-11049 Add tracking for model serving #3111
RHOAIENG-11049 Add tracking for model serving #3111
Conversation
8647eab
to
49dad49
Compare
49dad49
to
ddac6c0
Compare
frontend/src/pages/modelServing/screens/projects/kServeModal/ManageKServeModal.tsx
Show resolved
Hide resolved
…anageKServeModal.tsx
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
+ Coverage 80.87% 85.15% +4.27%
==========================================
Files 1239 1251 +12
Lines 26893 27415 +522
Branches 7041 7274 +233
==========================================
+ Hits 21750 23345 +1595
+ Misses 5143 4070 -1073
... and 631 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-11049
Description
Add Segment tracking for Model serving Deploy/Edit/Delete operations
How Has This Been Tested?
Manual testing by clicking in the UI and watching the events fired in the browser console
Those should all yield lines like the following in the browser console, when in dev-mode. The
outcome
property should match the action submit/cancel of the dialog.Test Impact
Manual testing as described above
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main