Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codecov-action to latest version #3123

Merged

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Aug 26, 2024

https://issues.redhat.com/browse/RHOAIENG-11851

Description

At some point in time a change was made to codecov where PRs from forked repos were no longer receiving codecov bot comments on the PR; the coverage report could not be uploaded. The error reported in our test action was Error: Codecov token not found.

This change bumps the version of the codecov-action library.

How Has This Been Tested?

Tested by posting this PR with the updated version and observing if a comment would be made by codecov.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (5e854fe) to head (622414c).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3123      +/-   ##
==========================================
- Coverage   80.88%   80.87%   -0.02%     
==========================================
  Files        1239     1239              
  Lines       26895    26895              
  Branches     7041     7041              
==========================================
- Hits        21755    21750       -5     
- Misses       5140     5145       +5     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e854fe...622414c. Read the comment docs.

@christianvogt christianvogt changed the title [WIP] update codecov-action to latest version update codecov-action to latest version Aug 26, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Aug 26, 2024
@emilys314
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a7ad26d into opendatahub-io:main Aug 26, 2024
8 checks passed
emilys314 pushed a commit to emilys314/odh-dashboard that referenced this pull request Aug 27, 2024
emilys314 pushed a commit to emilys314/odh-dashboard that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants