Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for lint error #3128

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jeff-phillips-18
Copy link
Contributor

Description

Fixes a lint error that got merged.

How Has This Been Tested?

Ran the lint command

Test Impact

None

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (415b3b3) to head (2907279).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
- Coverage   80.89%   80.83%   -0.07%     
==========================================
  Files        1239     1240       +1     
  Lines       26908    26946      +38     
  Branches     7043     7074      +31     
==========================================
+ Hits        21768    21782      +14     
- Misses       5140     5164      +24     
Files Coverage Δ
...ctionTypes/manage/ConnectionTypeDataFieldModal.tsx 80.28% <ø> (-0.28%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ad26d...2907279. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 936f907 into opendatahub-io:main Aug 27, 2024
8 checks passed
emilys314 pushed a commit to emilys314/odh-dashboard that referenced this pull request Aug 27, 2024
manaswinidas pushed a commit to manaswinidas/odh-dashboard that referenced this pull request Aug 27, 2024
emilys314 pushed a commit to emilys314/odh-dashboard that referenced this pull request Aug 27, 2024
@jeff-phillips-18 jeff-phillips-18 deleted the lint-fix branch August 27, 2024 14:21
openshift-merge-bot bot pushed a commit that referenced this pull request Aug 27, 2024
* Upversion Dashboard to v2.25.2

* Fix for lint error (#3128)

(cherry picked from commit 936f907)

---------

Co-authored-by: Jeff Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants