Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model registry status #3133

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Aug 28, 2024

Closes: RHOAIENG-11278

Description

This PR aims to update the status of the model registry by adding refresh interval.

How Has This Been Tested?

  1. create a model registry.
  2. check that the status of the model registry will update when it is available.

Test Impact

NA

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti ppadti requested review from mturley and gitdallas and removed request for Gkrumbach07 and lucferbux August 28, 2024 15:20
@ppadti
Copy link
Contributor Author

ppadti commented Aug 28, 2024

@mturley I am not sure should we use FAST_POLL_INTERVAL here until the status gets updated like we have for workbenches here: https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/pages/projects/screens/detail/notebooks/NotebookList.tsx#L25

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.85%. Comparing base (4a0626e) to head (e10d867).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
+ Coverage   80.84%   80.85%   +0.01%     
==========================================
  Files        1243     1243              
  Lines       27099    27099              
  Branches     7144     7144              
==========================================
+ Hits        21907    21911       +4     
+ Misses       5192     5188       -4     
Files with missing lines Coverage Δ
...modelRegistrySettings/useModelRegistriesBackend.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0626e...e10d867. Read the comment docs.

Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but i'm unsure of the answer to your question about using the faster interval. possibly something to discuss with design or pm

@mturley
Copy link
Contributor

mturley commented Sep 3, 2024

@ppadti let's leave it as the 30-second POLL_INTERVAL for now. There's a separate problem we need to address post-MVP where the registry is showing as Unavailable right after it's created (see thread here, I don't think we have an issue yet) which would complicate the logic of determining whether to use the faster poll interval here. If we decide we want to add that behavior after that is fixed we can revisit it I think.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ppadti

Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a758af8 into opendatahub-io:main Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants