-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-1106] Storage classes table #3155
Conversation
6299447
to
d68ef8a
Compare
321183e
to
dd46151
Compare
/lgtm |
e2096ab
to
eb6be9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-1106
Description
Added storage classes table which includes column sorting, labels, popovers, tooltips, requests to update the default or the enabled state of storage classes (the underlying metadata for each row), placeholders for future table related stories.
https://github.com/user-attachments/assets/1b7b71b8-39d0-4f4c-8a04-25be2517630d (cc @xianli123)How Has This Been Tested?
Manual and cypress tests. Running the dev environment via the root directory of the project (npm run dev) and navigating to
/storageClasses?devFeatureFlags=disableStorageClasses
should lead to the storage classes table so long as storage classes exist to be rendered. Here you can compare to the design and interact with the default radio buttons and enable switches to verify that behavior.Test Impact
Added cypress tests covering rendering of data & toggling "enable" switches and "default" radio selections.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main