Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-1106] Storage classes table #3155

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Sep 4, 2024

https://issues.redhat.com/browse/RHOAIENG-1106

Description

Added storage classes table which includes column sorting, labels, popovers, tooltips, requests to update the default or the enabled state of storage classes (the underlying metadata for each row), placeholders for future table related stories.

image https://github.com/user-attachments/assets/1b7b71b8-39d0-4f4c-8a04-25be2517630d (cc @xianli123)

How Has This Been Tested?

Manual and cypress tests. Running the dev environment via the root directory of the project (npm run dev) and navigating to /storageClasses?devFeatureFlags=disableStorageClasses should lead to the storage classes table so long as storage classes exist to be rendered. Here you can compare to the design and interact with the default radio buttons and enable switches to verify that behavior.

Test Impact

Added cypress tests covering rendering of data & toggling "enable" switches and "default" radio selections.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 87.66234% with 19 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (d786249) to head (eb6be9a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nd/src/pages/storageClasses/StorageClassesPage.tsx 50.00% 13 Missing ⚠️
frontend/src/pages/storageClasses/constants.ts 81.81% 2 Missing ⚠️
.../pages/storageClasses/StorageClassDefaultRadio.tsx 96.29% 1 Missing ⚠️
.../pages/storageClasses/StorageClassEnableSwitch.tsx 96.42% 1 Missing ⚠️
...rc/pages/storageClasses/StorageClassesTableRow.tsx 97.67% 1 Missing ⚠️
frontend/src/pages/storageClasses/utils.ts 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3155      +/-   ##
==========================================
+ Coverage   85.19%   85.26%   +0.06%     
==========================================
  Files        1253     1258       +5     
  Lines       27539    27680     +141     
  Branches     7335     7371      +36     
==========================================
+ Hits        23463    23600     +137     
- Misses       4076     4080       +4     
Files with missing lines Coverage Δ
...d/src/pages/storageClasses/StorageClassesTable.tsx 100.00% <100.00%> (ø)
frontend/src/services/StorageClassService.ts 77.77% <100.00%> (+65.27%) ⬆️
.../pages/storageClasses/StorageClassDefaultRadio.tsx 96.29% <96.29%> (ø)
.../pages/storageClasses/StorageClassEnableSwitch.tsx 96.42% <96.42%> (ø)
...rc/pages/storageClasses/StorageClassesTableRow.tsx 97.67% <97.67%> (ø)
frontend/src/pages/storageClasses/utils.ts 90.00% <80.00%> (+52.50%) ⬆️
frontend/src/pages/storageClasses/constants.ts 81.81% <81.81%> (ø)
...nd/src/pages/storageClasses/StorageClassesPage.tsx 54.76% <50.00%> (-1.24%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d786249...eb6be9a. Read the comment docs.

@Gkrumbach07
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Sep 6, 2024
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Gkrumbach07
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 78262f7 into opendatahub-io:main Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants