Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test file -- weird backend setup #3165

Merged

Conversation

andrewballantyne
Copy link
Member

We have an issue with where our backend test files are for development -- moving to where the others are. We will follow up with an investigation of our tsconfig to figure out how to fix this more generically.

Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt
Copy link
Contributor

christianvogt commented Sep 6, 2024

/lgtm

Tested the following commands, in the backend, successfully:

npm run build
npm run test:jest
npm run start:dev

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (e344d82) to head (f3b792b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3165      +/-   ##
==========================================
- Coverage   85.25%   85.23%   -0.03%     
==========================================
  Files        1258     1258              
  Lines       27681    27681              
  Branches     7371     7371              
==========================================
- Hits        23600    23594       -6     
- Misses       4081     4087       +6     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e344d82...f3b792b. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 85f2b31 into opendatahub-io:main Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants