Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Building an image for testing a custom MR API URL #3166

Closed
wants to merge 4 commits into from

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Sep 6, 2024

Based on #3021, I'm abusing our repo's CI to build an image for me. Nothing to see here, move along

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Sep 6, 2024
Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mturley. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley
Copy link
Contributor Author

mturley commented Sep 6, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Sep 6, 2024
@mturley mturley marked this pull request as ready for review September 6, 2024 20:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 6, 2024
@mturley mturley closed this Sep 6, 2024
@mturley mturley deleted the tmp-mr-url-image branch September 6, 2024 20:25
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (7813220) to head (56646f4).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3166      +/-   ##
==========================================
- Coverage   85.26%   85.26%   -0.01%     
==========================================
  Files        1258     1258              
  Lines       27684    27684              
  Branches     7372     7372              
==========================================
- Hits        23605    23604       -1     
- Misses       4079     4080       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7813220...56646f4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold This PR is hold for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants