Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add projects' descriptions to projects list view #3174

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Sep 9, 2024

Closes RHOAIENG-10493

Description

Adds the project description to the name column in the projects list view

How Has This Been Tested?

Manually, added e2e test check

Test Impact

None

Screen shot

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @tobiastal

Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

@jeff-phillips-18: GitHub didn't allow me to request PR reviews from the following users: tobiastal.

Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Closes RHOAIENG-10493

Description

Adds the project description to the name column in the projects list view

How Has This Been Tested?

Manually, added e2e test check

Test Impact

None

Screen shot

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @tobiastal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (aa3ef61) to head (4bd05f8).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ages/projects/screens/projects/ProjectTableRow.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3174      +/-   ##
==========================================
+ Coverage   85.27%   85.28%   +0.01%     
==========================================
  Files        1258     1258              
  Lines       27689    27691       +2     
  Branches     7372     7373       +1     
==========================================
+ Hits        23612    23617       +5     
+ Misses       4077     4074       -3     
Files with missing lines Coverage Δ
...rc/pages/projects/screens/projects/ProjectLink.tsx 100.00% <100.00%> (ø)
...ages/projects/screens/projects/ProjectTableRow.tsx 86.11% <50.00%> (-2.47%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3ef61...4bd05f8. Read the comment docs.

@jeff-phillips-18 jeff-phillips-18 force-pushed the project-list-description branch 2 times, most recently from 3fa6bb5 to 6055700 Compare September 10, 2024 14:09
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 39b023e into opendatahub-io:main Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants