Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-12440
Description
Restrict env var names to valid C identifiers as denoted by pattern:
^[_a-zA-Z][_a-zA-Z0-9]*$
Updated all mocks and tests to conform to the new pattern.
Updated error message
How Has This Been Tested?
Login as an admin
Go to Settings -> Connection types
Create a new connection type
Add a field
enter valid and invalid values for the env var
Observe the error is displayed and
Add
button disabled when an invalid env var value is entered.Test Impact
update unit tests
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @simrandhaliw