Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update valid env var pattern #3175

Merged

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-12440

Description

Restrict env var names to valid C identifiers as denoted by pattern: ^[_a-zA-Z][_a-zA-Z0-9]*$

Updated all mocks and tests to conform to the new pattern.

Updated error message
image

How Has This Been Tested?

Login as an admin
Go to Settings -> Connection types
Create a new connection type
Add a field
enter valid and invalid values for the env var

Observe the error is displayed and Add button disabled when an invalid env var value is entered.

Test Impact

update unit tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (aa3ef61) to head (c08261f).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3175   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files        1258     1258           
  Lines       27689    27690    +1     
  Branches     7372     7372           
=======================================
+ Hits        23612    23613    +1     
  Misses       4077     4077           
Files with missing lines Coverage Δ
frontend/src/concepts/connectionTypes/utils.ts 92.85% <100.00%> (+0.26%) ⬆️
...ctionTypes/manage/ConnectionTypeDataFieldModal.tsx 86.11% <100.00%> (+1.17%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3ef61...c08261f. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1f59036 into opendatahub-io:main Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants