-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mlmd and pipelines service to use constructUrl for URL generation #3177
Update mlmd and pipelines service to use constructUrl for URL generation #3177
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3177 +/- ##
=======================================
Coverage 85.27% 85.27%
=======================================
Files 1258 1258
Lines 27689 27689
Branches 7370 7370
=======================================
Hits 23613 23613
Misses 4076 4076 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
0740170
to
e90aa58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified here by creating a pipeline server and verifying mlmd resources were fetched after creating a new run with scalar metrics.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, jpuzz0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-12000
Description
adds a constructUrl option that can be used instead of manually entering service info for backend proxy helper
uses this for mlmd and pipelines
How Has This Been Tested?
make sure a pipelines server and mlmd server can fetch data
create a new pipeline server and verify backend is not crashing
Test Impact
none backend
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main