Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fastify maxParamLength to 253 for support max k8s names #3180

Merged

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-12443

Description

fastify default maxParamLength is 100.
Some of our URLs contain k8s resource names and since a k8s resource name can be up to 253 characters, we get invalid routes:

image

How Has This Been Tested?

Create a connection type with a name longer than 100 characters
Attempt to edit the connection type.

Same thing can be tested with accelerator profiles.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@andrewballantyne
Copy link
Member

/lgtm

Looks good to me... have not tested it though.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (aa3ef61) to head (3742e42).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3180   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files        1258     1258           
  Lines       27689    27689           
  Branches     7372     7372           
=======================================
  Hits        23612    23612           
  Misses       4077     4077           

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3ef61...3742e42. Read the comment docs.

@emilys314
Copy link
Contributor

emilys314 commented Sep 10, 2024

I tested with a connection type name of 0123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456 and it did fix the routing with this PR

Although I was also testing the accelerator profiles, which didn't have this error. Because it would prevent you from creating one with more than 253 characters. (There was no routing error for accelerator profiles)

Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 843e85a into opendatahub-io:main Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants