Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make accelorators field not required on workbench spawner page and model deployment modals #3181

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 10, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-12694

Description

Revert the changes made in https://github.com/opendatahub-io/odh-dashboard/pull/3102/files#diff-47693ad1cdd3bf50cbf06a60b941d5af0c9b0478f43311f7eca3e4f7d7972df8 to make the accelerator field non-required as discussed in https://redhat-internal.slack.com/archives/C07CQ4R4HMY/p1725973980856419?thread_ts=1725972888.178819&cid=C07CQ4R4HMY

Screenshot 2024-09-10 at 12 47 07 PM Screenshot 2024-09-10 at 12 47 41 PM

How Has This Been Tested?

Verify both the workbench spawner page and model deployment modals, the accelerator field should not be required now.

Test Impact

N/A, one-liner fix on UX, not sure if it is worth the effort to detect the * symbol exists...

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (917b4af) to head (26a3499).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3181      +/-   ##
==========================================
+ Coverage   85.27%   85.29%   +0.02%     
==========================================
  Files        1258     1258              
  Lines       27689    27689              
  Branches     7372     7372              
==========================================
+ Hits        23611    23617       +6     
+ Misses       4078     4072       -6     
Files with missing lines Coverage Δ
...r/screens/server/AcceleratorProfileSelectField.tsx 47.36% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917b4af...26a3499. Read the comment docs.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have the weirdness of "None" not actually being selectable (it works as a "clear selection" action) but that predates the change being reverted here so we can follow up for separate UX improvement there.

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f02500a into opendatahub-io:main Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants