Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] RHOAIENG-1109 Select Storage Classes in add cluster storage sections #3184

Closed
wants to merge 1 commit into from

Conversation

dpanshug
Copy link
Contributor

Closes: RHOAIENG-1109

Description

Added new field to select storage class to create pvc.

Available inside workbenches when creating new cluster storage.
Screenshot 2024-09-10 at 6 32 47 PM

When editing cluster storage storage class field will be disabled.
Screenshot 2024-09-10 at 6 22 39 PM

Default will be selected initially.
Screenshot 2024-09-10 at 6 22 20 PM

How Has This Been Tested?

Create a new cluster storage and you check list of storage classes in the field.
Create new workbench and select storage class in cluster storage.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main
    @xianli123

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Sep 10, 2024
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dpanshug
Copy link
Contributor Author

WIP: need to add tests

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (f02500a) to head (2776cfe).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...creens/spawner/storage/CreateNewStorageSection.tsx 57.14% 6 Missing ⚠️
frontend/src/pages/storageClasses/utils.ts 16.66% 5 Missing ⚠️
...ects/screens/detail/storage/ManageStorageModal.tsx 33.33% 2 Missing ⚠️
...rc/pages/projects/screens/spawner/storage/utils.ts 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3184      +/-   ##
==========================================
- Coverage   85.26%   85.24%   -0.03%     
==========================================
  Files        1258     1259       +1     
  Lines       27689    27724      +35     
  Branches     7372     7384      +12     
==========================================
+ Hits        23609    23633      +24     
- Misses       4080     4091      +11     
Files with missing lines Coverage Δ
frontend/src/api/k8s/pvcs.ts 100.00% <100.00%> (ø)
...c/pages/projects/screens/spawner/SpawnerFooter.tsx 77.68% <100.00%> (-0.19%) ⬇️
...src/pages/projects/screens/spawner/SpawnerPage.tsx 100.00% <100.00%> (ø)
...tend/src/pages/projects/screens/spawner/service.ts 68.88% <100.00%> (ø)
...src/pages/projects/screens/spawner/spawnerUtils.ts 81.30% <100.00%> (+0.08%) ⬆️
.../screens/spawner/storage/useDefaultStorageClass.ts 100.00% <100.00%> (ø)
frontend/src/pages/projects/types.ts 100.00% <ø> (ø)
...rc/pages/projects/screens/spawner/storage/utils.ts 96.96% <85.71%> (-3.04%) ⬇️
...ects/screens/detail/storage/ManageStorageModal.tsx 82.43% <33.33%> (-1.36%) ⬇️
frontend/src/pages/storageClasses/utils.ts 62.50% <16.66%> (-27.50%) ⬇️
... and 1 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02500a...2776cfe. Read the comment docs.

@Gkrumbach07
Copy link
Member

/close

this new pr build off this pr
#3212

@openshift-ci openshift-ci bot closed this Sep 13, 2024
Copy link
Contributor

openshift-ci bot commented Sep 13, 2024

@Gkrumbach07: Closed this PR.

In response to this:

/close

this new pr build off this pr
#3212

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants