-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] RHOAIENG-1109 Select Storage Classes in add cluster storage sections #3184
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WIP: need to add tests |
5da3372
to
2776cfe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3184 +/- ##
==========================================
- Coverage 85.26% 85.24% -0.03%
==========================================
Files 1258 1259 +1
Lines 27689 27724 +35
Branches 7372 7384 +12
==========================================
+ Hits 23609 23633 +24
- Misses 4080 4091 +11
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/close this new pr build off this pr |
@Gkrumbach07: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Closes: RHOAIENG-1109
Description
Added new field to select storage class to create pvc.
Available inside workbenches when creating new cluster storage.
When editing cluster storage storage class field will be disabled.
Default will be selected initially.
How Has This Been Tested?
Create a new cluster storage and you check list of storage classes in the field.
Create new workbench and select storage class in cluster storage.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
@xianli123