-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update table filters into separate chip groups #3202
update table filters into separate chip groups #3202
Conversation
0fc6f3d
to
30b3ebe
Compare
30b3ebe
to
3ba2a8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3202 +/- ##
==========================================
+ Coverage 85.29% 85.33% +0.03%
==========================================
Files 1266 1267 +1
Lines 27800 27827 +27
Branches 7400 7413 +13
==========================================
+ Hits 23712 23745 +33
+ Misses 4088 4082 -6
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Ran thru the filters, works well. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
https://issues.redhat.com/browse/RHOAIENG-12827
Description
How Has This Been Tested?
Manually hitting the different areas of the UI.
Connection type before and after:
Pipelines before and after:
All affected areas:
/connectionTypes
/pipelines/<namespace>
/experiments/<namespace>
/experiments/<namespace>/archived
/executions/<namespace>
/artifacts/<namespace>
/projects
Test Impact
Existing cypress tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @simrandhaliw