Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display storage class selected in workbenches #3214

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Sep 17, 2024

https://issues.redhat.com/browse/RHOAIENG-1110

Description

  1. Added a new column for the storage class in the cluster storage table when the feature flag is enabled
  2. shows class display name and description and sortable
  3. shows the deprecated storage class alert when atleast one of the storage class is disabled and attached to cluster storage and added a label

Cluster storage page

Screenshot 2024-09-17 at 1 04 34 PM

when storage class is deprecated/disabled

Screenshot 2024-09-16 at 5 31 10 PM

when storage class is deleted

Screenshot 2024-09-16 at 5 29 28 PM

How Has This Been Tested?

When feature flag is off

  1. Check the functionality remains same

When feature flag is on

  1. Go to the cluster storage tab from the Data science project Page
  2. Check for the new storage column
  3. Check whether its sortable
  4. Check when the storage class is disabled for the attached cluster storage the deprecated label along with the alert message is shown
  5. Check when the storage class is deleted for the attached cluster storage the deleted label is shown

Test Impact

Added cypress test to it

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1
Copy link
Contributor Author

pnaik1 commented Sep 17, 2024

/hold
until this PR-3212 gets merged

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Sep 17, 2024
@pnaik1
Copy link
Contributor Author

pnaik1 commented Sep 17, 2024

@xianli123 Can you please have a look at the screenshot attached above
When the class is deleted from OpenShift , I have added the deleted label, Can you verify this??
and do we still need the alert message here??

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.49%. Comparing base (b5351a7) to head (43b6019).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
.../src/pages/projects/screens/detail/storage/data.ts 37.50% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
+ Coverage   85.39%   85.49%   +0.10%     
==========================================
  Files        1277     1280       +3     
  Lines       28082    28229     +147     
  Branches     7487     7558      +71     
==========================================
+ Hits        23980    24134     +154     
+ Misses       4102     4095       -7     
Files with missing lines Coverage Δ
...s/projects/screens/detail/storage/StorageTable.tsx 100.00% <100.00%> (ø)
...rojects/screens/detail/storage/StorageTableRow.tsx 100.00% <100.00%> (ø)
.../src/pages/projects/screens/detail/storage/data.ts 44.44% <37.50%> (-55.56%) ⬇️

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5351a7...43b6019. Read the comment docs.

@xianli123
Copy link

Thanks @pnaik1! That works for me.

@pnaik1
Copy link
Contributor Author

pnaik1 commented Sep 18, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Sep 18, 2024
@pnaik1 pnaik1 force-pushed the rhoaieng-1110 branch 3 times, most recently from d8b7818 to 2b302b5 Compare September 19, 2024 13:55
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

this looks good, thanks for the changes

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2024
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 853029b into opendatahub-io:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants