Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fetch serving runtime templates with dashboard label #3222

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 18, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-12799

Description

Added back the label selector for 'opendatahub.io/dashboard': 'true' when fetching the templates.

How Has This Been Tested?

  1. Go to the serving runtimes page in the settings
  2. Duplicate a serving runtime template
  3. Go to the OpenShift console and find that template
  4. Remove the label 'opendatahub.io/dashboard': 'true' from the template
  5. Refresh the serving runtimes page in the dashboard
  6. Make sure the template without the label is not listed

Test Impact

There is no way to test the WebSocket watch API, the only way is to make sure the hook has been called with the selector option, so I updated that.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (da0aa67) to head (878dd3e).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   85.47%   85.46%   -0.01%     
==========================================
  Files        1279     1279              
  Lines       28161    28161              
  Branches     7525     7525              
==========================================
- Hits        24070    24069       -1     
- Misses       4091     4092       +1     
Files with missing lines Coverage Δ
frontend/src/api/k8s/templates.ts 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0aa67...878dd3e. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Sep 20, 2024

/lgtm
testing in the cluster, removing the label 'opendatahub.io/dashboard': 'true' from the template, the template is not listed in the serving runtimes page

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eed9e47 into opendatahub-io:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants