Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection type compatibility column #3225

Merged

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented Sep 18, 2024

https://issues.redhat.com/browse/RHOAIENG-13111

Description

Compatibility is assumed based on inspection of the environment variables stored in the connection type and secret by name. A model serving compatible connection requires the following env vars: 'AWS_ACCESS_KEY_ID', 'AWS_SECRET_ACCESS_KEY', 'AWS_S3_ENDPOINT', 'AWS_S3_BUCKET'

If all of these env vars are present, then we assume it is model serving compatible.

Connection instances:
image

Connection types:
image

How Has This Been Tested?

Enable the connection types feature flag.

Connection types:

  • Create a connection type in the admin section.
  • Add fields with at least the following required env vars: 'AWS_ACCESS_KEY_ID', 'AWS_SECRET_ACCESS_KEY', 'AWS_S3_ENDPOINT', 'AWS_S3_BUCKET'
  • Observe the connection type displays Model serving in the compatibility column

Connection instances:

  • Create a data connection. Make sure to include a value for the bucket.
  • Navigate to the project details Connections tab
  • Observe the data connection displays Model serving in the compatibility column

Test Impact

Added unit and cypress tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

@christianvogt christianvogt changed the title connection type compatibility column [WIP] connection type compatibility column Sep 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Sep 18, 2024
@christianvogt christianvogt force-pushed the ct-compatibility branch 2 times, most recently from 66c48b1 to c98e0ff Compare September 18, 2024 23:03
@christianvogt christianvogt changed the title [WIP] connection type compatibility column connection type compatibility column Sep 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 18, 2024
@christianvogt christianvogt force-pushed the ct-compatibility branch 2 times, most recently from e419366 to 9398323 Compare September 19, 2024 12:16
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.48%. Comparing base (51632ce) to head (7f71598).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...screens/detail/connections/ConnectionsTableRow.tsx 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
- Coverage   85.48%   85.48%   -0.01%     
==========================================
  Files        1279     1280       +1     
  Lines       28161    28190      +29     
  Branches     7525     7535      +10     
==========================================
+ Hits        24074    24097      +23     
- Misses       4087     4093       +6     
Files with missing lines Coverage Δ
...rc/concepts/connectionTypes/CompatibilityLabel.tsx 100.00% <100.00%> (ø)
frontend/src/concepts/connectionTypes/types.ts 100.00% <ø> (ø)
frontend/src/concepts/connectionTypes/utils.ts 94.02% <100.00%> (+1.17%) ⬆️
.../pages/connectionTypes/ConnectionTypesTableRow.tsx 67.92% <100.00%> (+5.70%) ⬆️
frontend/src/pages/connectionTypes/columns.ts 44.44% <ø> (ø)
...eens/detail/connections/connectionsTableColumns.ts 83.33% <ø> (ø)
...screens/detail/connections/ConnectionsTableRow.tsx 92.30% <88.88%> (-1.81%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51632ce...7f71598. Read the comment docs.

@christianvogt
Copy link
Contributor Author

/retest

@christianvogt
Copy link
Contributor Author

rebased
Needed to kick start the retest

@emilys314
Copy link
Contributor

/lgtm

looks good, everything is working

screenshots

image
image

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c40fd88 into opendatahub-io:main Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants