-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connection type compatibility column #3225
connection type compatibility column #3225
Conversation
frontend/src/pages/projects/screens/detail/connections/ConnectionsTableRow.tsx
Outdated
Show resolved
Hide resolved
66c48b1
to
c98e0ff
Compare
e419366
to
9398323
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3225 +/- ##
==========================================
- Coverage 85.48% 85.48% -0.01%
==========================================
Files 1279 1280 +1
Lines 28161 28190 +29
Branches 7525 7535 +10
==========================================
+ Hits 24074 24097 +23
- Misses 4087 4093 +6
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/retest |
9398323
to
7f71598
Compare
rebased |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-13111
Description
Compatibility is assumed based on inspection of the environment variables stored in the connection type and secret by name. A model serving compatible connection requires the following env vars: 'AWS_ACCESS_KEY_ID', 'AWS_SECRET_ACCESS_KEY', 'AWS_S3_ENDPOINT', 'AWS_S3_BUCKET'
If all of these env vars are present, then we assume it is model serving compatible.
Connection instances:
Connection types:
How Has This Been Tested?
Enable the connection types feature flag.
Connection types:
Model serving
in the compatibility columnConnection instances:
Connections
tabModel serving
in the compatibility columnTest Impact
Added unit and cypress tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
cc @simrandhaliw