Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @patternfly/react-core for menu fixes #3226

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes RHOAIENG-11967
Closes RHOAIENG-11118

Description

Update version of @patternfly/react-core to pickup fixes for dropdown and select to prevent inadvertent scrolling when the menu is opened.

How Has This Been Tested?

Tested locally
Enable connection types
Edit a connection type with enough fields to make the list scroll so that some items are not seen at the top of the page.
Scroll down to the initially non-visible fields.
Open the kebab menu for the fields, verify the menu opens and is visible.

Add a drop down field as one of the fields that are not visible initially.
Open the connection type preview pane.
Scroll down and open the dropdown from the dropdown field.
Verify the menu opens and is visible

Test Impact

None, this is a small change to the timing of the opening of the menu.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (6a6a03a) to head (40839b6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3226      +/-   ##
==========================================
- Coverage   85.47%   85.44%   -0.04%     
==========================================
  Files        1279     1279              
  Lines       28161    28161              
  Branches     7525     7525              
==========================================
- Hits        24071    24062       -9     
- Misses       4090     4099       +9     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6a03a...40839b6. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2e26a6f into opendatahub-io:main Sep 19, 2024
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the pf-update-select-fix branch September 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants