Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in Argo Workflow warning #3227

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ashley-o0o
Copy link
Contributor

Closes: RHOAIENG-9505

Description

Fixes small type error of a missing space in the Argo workflow warning

How Has This Been Tested?

Tested using the Cypress file argoAlert.cy.ts

Test Impact

No new tests added

Screenshots

Before:
Screenshot 2024-09-19 at 10 14 30 AM

After:
Screenshot 2024-09-19 at 10 16 31 AM
Screenshot 2024-09-19 at 10 16 48 AM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Sep 19, 2024
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ashley-o0o ashley-o0o marked this pull request as ready for review September 19, 2024 14:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (da0aa67) to head (b71e4e4).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3227   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files        1279     1279           
  Lines       28161    28161           
  Branches     7525     7525           
=======================================
+ Hits        24070    24071    +1     
+ Misses       4091     4090    -1     
Files with missing lines Coverage Δ
...s/pipelines/content/InvalidArgoDeploymentAlert.tsx 100.00% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0aa67...b71e4e4. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 75f526a into opendatahub-io:main Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants