Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arrow sorting to properly reflect item order #3232

Merged

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Sep 19, 2024

Closes: RHOAIENG-1146

Description

Updates the arrow sorting feature in the Resources page. When looking at list mode, the arrow is now pointing in the correct direction for the item order.

How Has This Been Tested?

Tested locally and on Cypress

Test Impact

No new tests added. Current test was modified to reflect new arrow direction change.

Screenshots

Before: (Arrow down for ASC)
Screenshot 2024-09-19 at 3 23 00 PM

After: (Arrow up for ASC, and down for DESC)
Screenshot 2024-09-19 at 3 23 23 PM
Screenshot 2024-09-19 at 3 23 31 PM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (75f526a) to head (fe67d89).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3232   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files        1279     1280    +1     
  Lines       28161    28190   +29     
  Branches     7525     7535   +10     
=======================================
+ Hits        24075    24100   +25     
- Misses       4086     4090    +4     
Files with missing lines Coverage Δ
.../pages/learningCenter/LearningCenterListHeader.tsx 100.00% <ø> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f526a...fe67d89. Read the comment docs.

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ashley-o0o - tested locally, everything looks great and sorting now works as expected based on the notes/comments in the ticket.

Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jenny-s51

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c9a5929 into opendatahub-io:main Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants