-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash if modelregistries namespace is not present in the DSC #3248
Don't crash if modelregistries namespace is not present in the DSC #3248
Conversation
460ae43
to
7692f82
Compare
/hold |
/unhold |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3248 +/- ##
==========================================
- Coverage 85.06% 85.04% -0.02%
==========================================
Files 1293 1293
Lines 28846 28846
Branches 7759 7759
==========================================
- Hits 24538 24533 -5
- Misses 4308 4313 +5
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
4cc6cb5
to
4abe660
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, gitdallas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Followup to #3239
Needed for https://issues.redhat.com/browse/RHOAIENG-12311
Description
See slack thread here. The above PR creates a situation where if model registry is not enabled on a cluster, the dashboard will crash on server start. This PR is an immediate fix for the crash, and I'll follow up with a second PR to switch us to using a ResourceWatcher so we make sure the namespace value is current in case it is not available yet when the dashboard starts.
This PR also fixes the same type in the frontend to make sure we are always being defensive when we try to read this value.
How Has This Been Tested?
Tested on https://console-openshift-console.apps.ods-qe-psi-01.osp.rh-ods.com/ which is old enough that its DSC has no modelregistry spec or status. Running the backend locally on main, verified that it crashes when using this cluster's API. Running the same way on this branch there is no crash.
Test Impact
N/A, no tests in the backend.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main