Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit for existing project connection instances #3250

Connection modal typeahead enhancements

5959ccd
Select commit
Loading
Failed to load commit list.
Merged

Edit for existing project connection instances #3250

Connection modal typeahead enhancements
5959ccd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 26, 2024 in 1s

84.90% (+0.04%) compared to ca27d1d

View this Pull Request on Codecov

84.90% (+0.04%) compared to ca27d1d

Details

Codecov Report

Attention: Patch coverage is 93.26923% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (ca27d1d) to head (5959ccd).

Files with missing lines Patch % Lines
...rc/concepts/connectionTypes/ConnectionTypeForm.tsx 84.00% 4 Missing ⚠️
frontend/src/concepts/connectionTypes/utils.ts 89.65% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3250      +/-   ##
==========================================
+ Coverage   84.85%   84.90%   +0.04%     
==========================================
  Files        1299     1299              
  Lines       28919    29001      +82     
  Branches     7770     7807      +37     
==========================================
+ Hits        24539    24623      +84     
+ Misses       4380     4378       -2     
Files with missing lines Coverage Δ
...onnectionTypes/fields/ConnectionTypeFormFields.tsx 100.00% <100.00%> (ø)
...8sNameDescriptionField/K8sNameDescriptionField.tsx 100.00% <100.00%> (ø)
.../k8s/K8sNameDescriptionField/ResourceNameField.tsx 100.00% <100.00%> (ø)
...cts/screens/detail/connections/ConnectionsList.tsx 100.00% <100.00%> (ø)
...ts/screens/detail/connections/ConnectionsTable.tsx 100.00% <100.00%> (ø)
...eens/detail/connections/ManageConnectionsModal.tsx 93.47% <100.00%> (+4.08%) ⬆️
.../projects/screens/detail/data-connections/utils.ts 97.67% <100.00%> (+0.05%) ⬆️
frontend/src/concepts/connectionTypes/utils.ts 92.72% <89.65%> (-1.18%) ⬇️
...rc/concepts/connectionTypes/ConnectionTypeForm.tsx 88.23% <84.00%> (-0.66%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca27d1d...5959ccd. Read the comment docs.