-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage class support for notebook PVCs #3255
Add storage class support for notebook PVCs #3255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well on the KFNBC
/lgtm
had to fix test @DaoDaoNoCode |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
=======================================
Coverage 84.96% 84.97%
=======================================
Files 1302 1302
Lines 29101 29103 +2
Branches 7828 7829 +1
=======================================
+ Hits 24727 24730 +3
+ Misses 4374 4373 -1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
abfe18e
to
f46795a
Compare
/retest |
1 similar comment
/retest |
@Gkrumbach07 Can you rebase your PR with main? That should fix the test. |
f46795a
to
413093a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-13395
Description
This PR adds support for setting the default storage class for the jupyter tile.
Key changes:
How Has This Been Tested?
Test Impact
updated test mocks and added test to make sure default storage class was passed to the backend
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main