Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage class support for notebook PVCs #3255

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Sep 25, 2024

https://issues.redhat.com/browse/RHOAIENG-13395

Description

This PR adds support for setting the default storage class for the jupyter tile.
Key changes:

  • Added storageClassName field to NotebookData type in both frontend and backend.
  • fix test mocks that where creating a new type

How Has This Been Tested?

  1. enable storage class feature flag
  2. set storage class in dashboard config
  3. spawn a notebook in jupyter tile
  4. check that notebook created is using the storage class in the dashboard config
  5. remove the storage class from the dashboard config
  6. spawn it again and check that it uses the default set in the storage class admin page
  7. turn off the feature flag
  8. spawn it again, check that it uses the default openshift storage class

Test Impact

updated test mocks and added test to make sure default storage class was passed to the backend

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well on the KFNBC
/lgtm

@Gkrumbach07
Copy link
Member Author

had to fix test @DaoDaoNoCode

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (a0d40fd) to head (413093a).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3255   +/-   ##
=======================================
  Coverage   84.96%   84.97%           
=======================================
  Files        1302     1302           
  Lines       29101    29103    +2     
  Branches     7828     7829    +1     
=======================================
+ Hits        24727    24730    +3     
+ Misses       4374     4373    -1     
Files with missing lines Coverage Δ
.../notebookController/screens/server/SpawnerPage.tsx 65.00% <100.00%> (+0.44%) ⬆️
frontend/src/types.ts 100.00% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d40fd...413093a. Read the comment docs.

@Gkrumbach07
Copy link
Member Author

/retest

1 similar comment
@DaoDaoNoCode
Copy link
Member

/retest

@DaoDaoNoCode
Copy link
Member

@Gkrumbach07 Can you rebase your PR with main? That should fix the test.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2024
@Gkrumbach07
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 50a1054 into opendatahub-io:main Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants