Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable model registry feature by default #3259

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Sep 25, 2024

Closes RHOAIENG-12588.
Should not be merged until all other Model Registry MVP dev issues are closed. At time of writing, these are the only issues remaining:

Description

Changes the default value of the disableModelRegistry feature flag to false in anticipation of the Model Registry MVP tech preview release.

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@mturley
Copy link
Contributor Author

mturley commented Sep 25, 2024

/hold
Holding this until the other MVP issues are closed.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Sep 25, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (47aabd3) to head (084c8cb).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
+ Coverage   84.84%   84.87%   +0.02%     
==========================================
  Files        1299     1299              
  Lines       28920    28920              
  Branches     7771     7771              
==========================================
+ Hits        24538    24545       +7     
+ Misses       4382     4375       -7     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aabd3...084c8cb. Read the comment docs.

@YuliaKrimerman
Copy link
Contributor

/ lgtm

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mturley
Copy link
Contributor Author

mturley commented Sep 26, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Sep 26, 2024
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: manaswinidas, YuliaKrimerman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c4ce86c into opendatahub-io:main Sep 26, 2024
8 checks passed
@mturley mturley deleted the mr-feature-flag branch September 26, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants