-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable model registry feature by default #3259
Enable model registry feature by default #3259
Conversation
Signed-off-by: Mike Turley <[email protected]>
/hold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3259 +/- ##
==========================================
+ Coverage 84.84% 84.87% +0.02%
==========================================
Files 1299 1299
Lines 28920 28920
Branches 7771 7771
==========================================
+ Hits 24538 24545 +7
+ Misses 4382 4375 -7 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/ lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: manaswinidas, YuliaKrimerman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes RHOAIENG-12588.
Should not be merged until all other Model Registry MVP dev issues are closed. At time of writing, these are the only issues remaining:
Description
Changes the default value of the
disableModelRegistry
feature flag to false in anticipation of the Model Registry MVP tech preview release.How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main