Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label group truncation #3266

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

christianvogt
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-12443

Description

This works around an issue with PF: patternfly/patternfly#7104

Label components within a LabelGroup do not truncate when placed within a confined container.

How Has This Been Tested?

  • Create a connection type with a very long named category.
  • Observe the category truncation on the connection type table.

Before:
image

After:
image

Test Impact

N/A
Visual change only.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (6ca046e) to head (9bb6c1b).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3266      +/-   ##
==========================================
+ Coverage   84.90%   84.97%   +0.07%     
==========================================
  Files        1299     1302       +3     
  Lines       29001    29101     +100     
  Branches     7807     7828      +21     
==========================================
+ Hits        24623    24730     +107     
+ Misses       4378     4371       -7     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063d974...9bb6c1b. Read the comment docs.

@emilys314
Copy link
Contributor

/lgtm

looking good
image

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 296dceb into opendatahub-io:main Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants