Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disablePipelineExperiments feature flag #3273

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 30, 2024

JIRA: RHOAIENG-11336

Description

Remove the feature flag disablePipelineExperiments and the supported area PIPELINE_EXPERIMENTS. Make experiments always enabled.

How Has This Been Tested?

Make sure all the tests are passed and the pipeline/experiments can run/navigate correctly. Make sure nothing is broken in the pipelines area.
Also, deploy this branch to a live cluster to see if anything is broken.

Test Impact

N/A, updated mock dashboard config due to API change.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (228e221) to head (8c35856).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3273      +/-   ##
==========================================
- Coverage   84.87%   84.84%   -0.04%     
==========================================
  Files        1306     1306              
  Lines       29196    29144      -52     
  Branches     7885     7855      -30     
==========================================
- Hits        24780    24727      -53     
- Misses       4416     4417       +1     
Files with missing lines Coverage Δ
frontend/src/concepts/areas/const.ts 100.00% <ø> (ø)
frontend/src/concepts/areas/types.ts 100.00% <ø> (ø)
...c/concepts/pipelines/content/createRun/RunPage.tsx 100.00% <ø> (+2.32%) ⬆️
...epts/pipelines/content/createRun/RunPageFooter.tsx 84.00% <100.00%> (+1.85%) ⬆️
...un/contentSections/ProjectAndExperimentSection.tsx 100.00% <100.00%> (+7.69%) ⬆️
...ntent/createRun/contentSections/RunTypeSection.tsx 100.00% <ø> (ø)
.../src/concepts/pipelines/content/createRun/utils.ts 100.00% <100.00%> (ø)
...ecurringRun/PipelineRecurringRunDetailsActions.tsx 93.18% <ø> (-0.30%) ⬇️
...sDetails/pipelineRun/PipelineRunDetailsActions.tsx 79.62% <100.00%> (-0.73%) ⬇️
...Details/pipelineRun/SelectedNodeInputOutputTab.tsx 93.33% <100.00%> (-0.11%) ⬇️
... and 12 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228e221...8c35856. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. I ran through the code live and everything checks out and the code seems straightforward. going to wait for one more review to merge

/lgtm

@pnaik1
Copy link
Contributor

pnaik1 commented Oct 3, 2024

/lgtm
tested in live cluster, nothing is broken in the pipelines area.

@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9ed0a82 into opendatahub-io:main Oct 3, 2024
8 checks passed
lokeshrangineni pushed a commit to lokeshrangineni/odh-dashboard that referenced this pull request Oct 3, 2024
dmartinol pushed a commit to dmartinol/odh-dashboard that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants