Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config map nim model name fetch #3276

Merged

fix: retrieve ConfigMap using service account and added ${uid} to PVC…

bc3c9ac
Select commit
Loading
Failed to load commit list.
Merged

Config map nim model name fetch #3276

fix: retrieve ConfigMap using service account and added ${uid} to PVC…
bc3c9ac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 0s

84.81% (-0.06%) compared to 228e221

View this Pull Request on Codecov

84.81% (-0.06%) compared to 228e221

Details

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.81%. Comparing base (228e221) to head (bc3c9ac).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/api/k8s/servingRuntimes.ts 66.66% 5 Missing ⚠️
...rc/pages/modelServing/screens/projects/nimUtils.ts 42.85% 4 Missing ⚠️
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 0.00% 1 Missing ⚠️
...s/projects/NIMServiceModal/NIMModelListSection.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3276      +/-   ##
==========================================
- Coverage   84.87%   84.81%   -0.06%     
==========================================
  Files        1306     1306              
  Lines       29196    29207      +11     
  Branches     7885     7890       +5     
==========================================
- Hits        24780    24773       -7     
- Misses       4416     4434      +18     
Files with missing lines Coverage Δ
...d/src/pages/modelServing/screens/projects/utils.ts 97.27% <100.00%> (+0.42%) ⬆️
...projects/NIMServiceModal/DeployNIMServiceModal.tsx 4.95% <0.00%> (-1.00%) ⬇️
...s/projects/NIMServiceModal/NIMModelListSection.tsx 1.63% <0.00%> (ø)
...rc/pages/modelServing/screens/projects/nimUtils.ts 52.27% <42.85%> (ø)
frontend/src/api/k8s/servingRuntimes.ts 94.39% <66.66%> (-4.55%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228e221...bc3c9ac. Read the comment docs.