Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in model registry #3284

Merged
merged 4 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const ModelRegistrySelector: React.FC<ModelRegistrySelectorProps> = ({
};

const options = [
<SelectGroup label="Select a model registry" key="all">
<SelectGroup label="All model registries" key="all">
<SelectList>
{modelRegistryServices.map((mr) => (
<SelectOption
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,27 @@ const ModelVersionDetailsView: React.FC<ModelVersionDetailsViewProps> = ({
</DashboardDescriptionListGroup>
</>
)}
</DescriptionList>
<Title style={{ marginTop: '1em' }} headingLevel={TextVariants.h3}>
Source model format
</Title>
<DescriptionList isFillColumns>
<DashboardDescriptionListGroup
title="Source model format"
title="Name"
isEmpty={modelArtifact.size === 0 || !modelArtifact.items[0].modelFormatName}
contentWhenEmpty="No source model format"
>
{modelArtifact.items[0]?.modelFormatName}
</DashboardDescriptionListGroup>
<DashboardDescriptionListGroup
title="Version"
isEmpty={modelArtifact.size === 0 || !modelArtifact.items[0].modelFormatVersion}
contentWhenEmpty="No source model format version"
>
{modelArtifact.items[0]?.modelFormatVersion}
</DashboardDescriptionListGroup>
</DescriptionList>
<DescriptionList isFillColumns style={{ marginTop: '2em' }}>
<DashboardDescriptionListGroup
title="Author"
tooltip={
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
ToolbarItem,
ToolbarToggleGroup,
} from '@patternfly/react-core';
import { FilterIcon } from '@patternfly/react-icons';
import { FilterIcon, SearchIcon } from '@patternfly/react-icons';
import { SearchType } from '~/concepts/dashboard/DashboardSearchField';
import { ModelVersion } from '~/concepts/modelRegistry/types';
import SimpleSelect from '~/components/SimpleSelect';
Expand Down Expand Up @@ -35,6 +35,7 @@ const ModelVersionsArchiveListView: React.FC<ModelVersionsArchiveListViewProps>
if (unfilteredmodelVersions.length === 0) {
return (
<EmptyModelRegistryState
headerIcon={SearchIcon}
testid="empty-archive-state"
title="No archived versions"
description="You can archive the active versions that you no longer use. You can restore an archived versions to make it active."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ const RegisteredModelSelector: React.FC<RegisteredModelSelectorProps> = ({
return (
<TypeaheadSelect
id="model-name"
onClearSelection={() => setRegisteredModelId('')}
selectOptions={options}
placeholder="Select a registered model"
noOptionsFoundMessage={(filter) => `No results found for "${filter}"`}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
ToolbarItem,
ToolbarToggleGroup,
} from '@patternfly/react-core';
import { FilterIcon } from '@patternfly/react-icons';
import { FilterIcon, SearchIcon } from '@patternfly/react-icons';
import { SearchType } from '~/concepts/dashboard/DashboardSearchField';
import { RegisteredModel } from '~/concepts/modelRegistry/types';
import SimpleSelect from '~/components/SimpleSelect';
Expand Down Expand Up @@ -39,6 +39,7 @@ const RegisteredModelsArchiveListView: React.FC<RegisteredModelsArchiveListViewP
if (unfilteredRegisteredModels.length === 0) {
return (
<EmptyModelRegistryState
headerIcon={SearchIcon}
manaswinidas marked this conversation as resolved.
Show resolved Hide resolved
testid="empty-archive-model-state"
title="No archived models"
description="You can archive the active models that you no longer use. You can restore an archived
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const ModelRegistriesManagePermissions: React.FC = () => {
description="Manage access to this model registry for individual users and user groups, and for service accounts in a project."
breadcrumb={
<Breadcrumb>
<BreadcrumbItem>Settings</BreadcrumbItem>
<BreadcrumbItem
render={() => <Link to="/modelRegistrySettings">Model registry settings</Link>}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ const CustomServingRuntimeAddTemplate: React.FC<CustomServingRuntimeAddTemplateP
}
breadcrumb={
<Breadcrumb>
<BreadcrumbItem>Settings</BreadcrumbItem>
<BreadcrumbItem render={() => <Link to="/servingRuntimes">Serving runtimes</Link>} />
{existingTemplate && (
<BreadcrumbItem>
Expand Down
Loading