Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MR): 12864 disable archive for mr/mv if has deploys #3292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gitdallas
Copy link
Contributor

closes: https://issues.redhat.com/browse/RHOAIENG-12864

Description

disable archiving models/versions with deploys

mr list page:
image

mr detail and versions list page:
image
image

mr version detail page:
image

How Has This Been Tested?

tested locally with mr cluster

Test Impact

tried adding tests, but cypress doesn't seem to call the k8s inferencemodel endpoint? will try again when i come back from vacation if still necesssary

cypress activity:
image
network activity for k8s inferencemodel in the actual app:
image

Request review criteria:

make sure that in all places where you can archive a model or version, you cannot do it if it has a deploy... but otherwise you can.

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (c4ae140) to head (284829b).

Files with missing lines Patch % Lines
...reens/RegisteredModels/RegisteredModelTableRow.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3292   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files        1321     1321           
  Lines       29446    29468   +22     
  Branches     8037     8051   +14     
=======================================
+ Hits        24983    25003   +20     
- Misses       4463     4465    +2     
Files with missing lines Coverage Δ
...creens/ModelVersionDetails/ModelVersionDetails.tsx 88.37% <ø> (ø)
...ersionDetails/ModelVersionDetailsHeaderActions.tsx 86.11% <100.00%> (+0.81%) ⬆️
...elRegistry/screens/ModelVersions/ModelVersions.tsx 100.00% <100.00%> (ø)
...reens/ModelVersions/ModelVersionsHeaderActions.tsx 100.00% <100.00%> (ø)
...istry/screens/ModelVersions/ModelVersionsTable.tsx 100.00% <100.00%> (ø)
...ry/screens/ModelVersions/ModelVersionsTableRow.tsx 96.15% <100.00%> (+0.23%) ⬆️
.../screens/RegisteredModels/RegisteredModelTable.tsx 100.00% <100.00%> (ø)
...reens/RegisteredModels/RegisteredModelTableRow.tsx 93.02% <66.66%> (-1.98%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ae140...284829b. Read the comment docs.

@gitdallas gitdallas force-pushed the fix/disable-archive-if-deploys branch from 980ca3b to 1cb71d6 Compare October 10, 2024 15:39
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

About the tests, @gitdallas did you try adding an intercept with mock data ?

@gitdallas
Copy link
Contributor Author

@manaswinidas yea i just threw this PR up prior to going on PTO incase it needed to get picked up urgently or something happened 😆

i was mocking it, but after debugging with mike it turns out the intercept wasn't working because it wasn't also intercepting the call to projects, which affected the URL of the inferenceService intercept 😵 updating PR soon with tests and cleanup

@gitdallas gitdallas force-pushed the fix/disable-archive-if-deploys branch from 1cb71d6 to 284829b Compare October 15, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants