Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(quality): add data-testid for the Launch standalone notebook server button #3294

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Oct 3, 2024

Description

How Has This Been Tested?

PR checks

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges: quay.io/opendatahub/odh-dashboard:pr-3294

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jiridanek
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (33ea696) to head (2826c85).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3294      +/-   ##
==========================================
- Coverage   84.84%   84.84%   -0.01%     
==========================================
  Files        1307     1307              
  Lines       29238    29238              
  Branches     7902     7902              
==========================================
- Hits        24808    24807       -1     
- Misses       4430     4431       +1     
Files with missing lines Coverage Δ
.../projects/screens/projects/LaunchJupyterButton.tsx 55.55% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ea696...2826c85. Read the comment docs.

@jiridanek
Copy link
Member Author

jiridanek commented Oct 4, 2024

/unhold

the data-testid is present when I deploy dashboard from quay.io/opendatahub/odh-dashboard:pr-3294

before

image

now

Screenshot 2024-10-04 at 8 50 07 AM

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Oct 4, 2024
@jiridanek
Copy link
Member Author

/assign manosnoam ConorOM1

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@jiridanek: GitHub didn't allow me to assign the following users: ConorOM1.

Note that only opendatahub-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign manosnoam ConorOM1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

jiridanek commented Oct 4, 2024

/cc manosnoam
that's the right command, https://prow.k8s.io/command-help#cc

@openshift-ci openshift-ci bot requested a review from manosnoam October 4, 2024 06:57
@jiridanek jiridanek changed the title NO-JIRA: chore(quality): add data-testid for the Launch standalone notebook server button NO-JIRA: chore(quality): add data-testid for the Launch standalone notebook server button Oct 4, 2024
Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 6, 2024
Copy link
Contributor

openshift-ci bot commented Oct 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 85ce695 into opendatahub-io:main Oct 6, 2024
8 checks passed
@jiridanek jiridanek deleted the patch-1 branch October 7, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants