Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/APPENG-2738: NIM Cypress E2E tests #3298

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Task/APPENG-2738: NIM Cypress E2E tests #3298

wants to merge 33 commits into from
+838 −3

Commits on Oct 4, 2024

  1. test: added mocks and interceptors for nim cypress tests 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9947f96 View commit details
    Browse the repository at this point in the history

  2. Merging the base test cases of Daniel and Lokesh's code to the Tomer'… 

    …s standalone cypress test suite.
    @lokeshrangineni @TomerFi
    lokeshrangineni authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ba0f98c View commit details
    Browse the repository at this point in the history

  3. Reverting the mock changes which are not needed.

    @lokeshrangineni @TomerFi
    lokeshrangineni authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d103247 View commit details
    Browse the repository at this point in the history

  4. nim-specific classes and functions, partial rework of deployment test (… 

    …#2)

Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b1e48d3 View commit details
    Browse the repository at this point in the history

  5. Checking in the cypress test covers to validate all the scenarios to … 

    …render nim and all other cards on overview and model tab when there are no ServingRuntimes configured.
    @lokeshrangineni @TomerFi
    lokeshrangineni authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2c7152d View commit details
    Browse the repository at this point in the history

  6. Added mockNimServingRuntimeTemplate mock function 

    Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2424ab3 View commit details
    Browse the repository at this point in the history

  7. mocking deploy respurces (WIP) 

    Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8175aa6 View commit details
    Browse the repository at this point in the history

  8. Completed deployment tests 

    Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1d80e39 View commit details
    Browse the repository at this point in the history

  9. Added new test cases to validate if the nim is not enabled 

     * when combination of configurations to enable nim models are not configured properly.
    @lokeshrangineni @TomerFi
    lokeshrangineni authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b662f9f View commit details
    Browse the repository at this point in the history

  10. test: added test cases for deleting model from the project models tab 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    47306a1 View commit details
    Browse the repository at this point in the history

  11. * Added new test cases to validate the model serving menu item when t… 

    …here are deployments and no deployments. (#9)

* Moved the utility method to nimUtils.ts
    @lokeshrangineni @TomerFi
    lokeshrangineni authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    34ab9df View commit details
    Browse the repository at this point in the history

  12. test: cleanups 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e57074a View commit details
    Browse the repository at this point in the history

  13. adding const for modal dialog title 

    Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b5c58a8 View commit details
    Browse the repository at this point in the history

  14. test cases for list of models in different pages/tabs 

    Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    db769a1 View commit details
    Browse the repository at this point in the history

  15. linting fixes 

    Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6d82381 View commit details
    Browse the repository at this point in the history

  16. removed experimentalStudio option 

    Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    5de4b14 View commit details
    Browse the repository at this point in the history

  17. test: split nim tests per pages (#13) 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a765cb9 View commit details
    Browse the repository at this point in the history

  18. testing more buttons in modal dialog (#14) 

    Signed-off-by: Daniele Martinoli <[email protected]>
    @dmartinol @TomerFi
    dmartinol authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e23d11a View commit details
    Browse the repository at this point in the history

  19. Added a test case to address there is a failure in loading Nvidia Nim… 

    … model images then error message should be displayed.

Added experimentalStudio flag to cypress.config.ts but disabled it by default.
    @lokeshrangineni @TomerFi
    lokeshrangineni authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ca6ef78 View commit details
    Browse the repository at this point in the history

  20. Added a test case to address there is a failure in loading Nvidia Nim… 

    … model images then error message should be displayed.

Added experimentalStudio flag to cypress.config.ts but disabled it by default.
    @lokeshrangineni @TomerFi
    lokeshrangineni authored and TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b1c2492 View commit details
    Browse the repository at this point in the history

  21. test: fix linting errors 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c480d4e View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. test: fix review change requests 1 - see body 

    - Use JSON object instead of string in mocking of NIM images configmap
- Remove experiementalStudio cypres config param
- Add mock for NIM project

Co-authored-by: Daniele Martinoli <[email protected]>
Co-authored-by: lokeshrangineni <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi @dmartinol @lokeshrangineni
    3 people committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    baf470e View commit details
    Browse the repository at this point in the history

  2. test: fix review change requests 2 - see body 

    - Add nim-serving interception to odh intercept type safety mechanism
- Add accelerators interception to odh intercept type safety mechanism

Co-authored-by: Daniele Martinoli <[email protected]>
Co-authored-by: lokeshrangineni <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi @dmartinol @lokeshrangineni
    3 people committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7da5544 View commit details
    Browse the repository at this point in the history

  3. test: create page objects for verifying nim model tabels 

    Co-authored-by: Daniele Martinoli <[email protected]>
Co-authored-by: lokeshrangineni <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi @dmartinol @lokeshrangineni
    3 people committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    eba0293 View commit details
    Browse the repository at this point in the history

  4. Update frontend/src/__tests__/cypress/cypress/tests/mocked/projects/m… 

    …odelServingNim.cy.ts

Co-authored-by: Andrew Ballantyne <[email protected]>
    @TomerFi @andrewballantyne
    TomerFi and andrewballantyne authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ec116f6 View commit details
    Browse the repository at this point in the history

  5. test: fix linting errors 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bdc58ab View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. test: rewrite test case for global model list nim 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    eaa0e47 View commit details
    Browse the repository at this point in the history

  2. test: fix linting errors 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    dd7ac09 View commit details
    Browse the repository at this point in the history

  3. test: rewrite test case for project overview list nim 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7c06f11 View commit details
    Browse the repository at this point in the history

  4. test: rewrite test case for project models tab list nim 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    aed9685 View commit details
    Browse the repository at this point in the history

  5. test: cleanups 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1cafc5d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. test: rewrite test cases nim enablement 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    cb01605 View commit details
    Browse the repository at this point in the history

  2. test: final touchups 

    Signed-off-by: Tomer Figenblat <[email protected]>
    @TomerFi
    TomerFi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    bd71dc4 View commit details
    Browse the repository at this point in the history