Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update empty pipeline server page button variant #3303

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Oct 4, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-9209

Description

Updated the configure server button variant on pipelines page to make it primary.

Screenshot 2024-10-04 at 11 43 28 AM

How Has This Been Tested?

Go to the project that doesn't have a pipeline server configured, make sure the configure server button is the primary style on both the projects page and the pipelines global page.

Test Impact

N/A, minor UX update.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (1ef1c29) to head (bff8f6b).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...cepts/pipelines/EnsureCompatiblePipelineServer.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3303      +/-   ##
==========================================
+ Coverage   84.80%   84.84%   +0.03%     
==========================================
  Files        1307     1308       +1     
  Lines       29195    29225      +30     
  Branches     7883     7893      +10     
==========================================
+ Hits        24760    24795      +35     
+ Misses       4435     4430       -5     
Files with missing lines Coverage Δ
...s/pipelines/global/PipelineCoreApplicationPage.tsx 100.00% <ø> (ø)
...cepts/pipelines/EnsureCompatiblePipelineServer.tsx 86.66% <0.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef1c29...bff8f6b. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Oct 7, 2024

We do have a Configure pipeline server button in the overview page, Are we not supposed to change that as well?

Screenshot 2024-10-07 at 5 09 15 PM

@DaoDaoNoCode
Copy link
Member Author

DaoDaoNoCode commented Oct 9, 2024

@pnaik1 I don't think so, that's in a card and we should align the button style with other cards, and keep it as a link variant.

Screenshot 2024-10-09 at 9 43 26 AM

This is my understanding, maybe @yannnz could chime in here and give opinions.

Copy link
Contributor

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

the buttons are updated on project pipeline and global pipeline page.
Screenshot 2024-10-09 at 8 18 31 PM

@Gkrumbach07
Copy link
Member

i agree i think the card needs to stay as link due to the other cards having their action buttons be link too. The jira was concerned with our full pages not using the primary variant

so this lgtm

/approve

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dpanshug, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 25c0564 into opendatahub-io:main Oct 9, 2024
8 checks passed
@yannnz
Copy link

yannnz commented Oct 11, 2024

Sorry there was a vpn issue in Beijing office, those comments didn't show up to me in previous days. I think this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants