Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable manage permissions when no rolebinding present for the default group #3306

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Oct 7, 2024

Closes: RHOAIENG-13091

Description

This PR aims to disable the Manage Permissions when model registry is in not ready state.
Screenshot 2024-10-04 at 8 02 54 PM

Screenshot 2024-10-10 at 8 53 55 PM

How Has This Been Tested?

Create a model registry
when Model registry is in progressing state, Manage permissions on the model registry table will be disabled.

Test Impact

Updated cypress test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (33ea696) to head (0f301f3).
Report is 30 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3306      +/-   ##
==========================================
- Coverage   84.84%   84.81%   -0.04%     
==========================================
  Files        1307     1309       +2     
  Lines       29238    29329      +91     
  Branches     7902     7986      +84     
==========================================
+ Hits        24808    24874      +66     
- Misses       4430     4455      +25     
Files with missing lines Coverage Δ
...ges/modelRegistrySettings/ModelRegistriesTable.tsx 100.00% <100.00%> (ø)
.../modelRegistrySettings/ModelRegistriesTableRow.tsx 96.42% <100.00%> (+3.09%) ⬆️
...es/modelRegistrySettings/ModelRegistrySettings.tsx 100.00% <100.00%> (ø)

... and 151 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ea696...0f301f3. Read the comment docs.

@ppadti ppadti force-pushed the RHOAIENG-13091 branch 2 times, most recently from 4324824 to 57fab64 Compare October 7, 2024 11:57
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, one small nitpick @ppadti

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ppadti !

Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley
Copy link
Contributor

mturley commented Oct 11, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 6ab6afd into opendatahub-io:main Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants