Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection card update #3309

Merged

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Oct 7, 2024

Closes: RHOAIENG-13140

Description

Updates the data connections card with new contents on both the home page and the data science projects page. The Connections card on the data science projects page now links to the connections tab.

How Has This Been Tested?

Tested locally

Test Impact

No tests added

Screenshots

Screenshot 2024-10-07 at 3 37 15 PM

----------------------

Screenshot 2024-10-07 at 3 38 49 PM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (355fbf7) to head (65e4ba5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...il/overview/configuration/ConfigurationSection.tsx 57.14% 3 Missing ⚠️
...rontend/src/pages/home/aiFlows/ProjectsGallery.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3309      +/-   ##
==========================================
- Coverage   84.76%   84.75%   -0.01%     
==========================================
  Files        1309     1309              
  Lines       29318    29324       +6     
  Branches     7981     7985       +4     
==========================================
+ Hits        24850    24855       +5     
- Misses       4468     4469       +1     
Files with missing lines Coverage Δ
...rontend/src/pages/home/aiFlows/ProjectsGallery.tsx 90.00% <66.66%> (-4.12%) ⬇️
...il/overview/configuration/ConfigurationSection.tsx 78.26% <57.14%> (-5.08%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355fbf7...65e4ba5. Read the comment docs.

@christianvogt
Copy link
Contributor

@ashley-o0o for now we still need to conditionally render the new connection type features behind the feature flag.

@ashley-o0o ashley-o0o force-pushed the 13140/connections-update branch 2 times, most recently from 58823d8 to f1c557e Compare October 9, 2024 14:40
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against current mocks
/lgtm

@jeff-phillips-18
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2024
@christianvogt
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 66a4b71 into opendatahub-io:main Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants