-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation and copy action for the Pod name in the Pipeline run graph execution node drawer #3312
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
==========================================
+ Coverage 84.84% 84.86% +0.02%
==========================================
Files 1321 1321
Lines 29446 29447 +1
Branches 8037 8038 +1
==========================================
+ Hits 24983 24990 +7
+ Misses 4463 4457 -6
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
UI looks good to me. Thanks. One thing I want to double check is if this pod name always displays in the UI even the pod has been expired? |
@yannnz, yes the pod name is still there. |
5bcfb0e
to
7b50016
Compare
@Gkrumbach07 @yannnz Fixed that width issue |
...rc/concepts/pipelines/content/pipelinesDetails/pipelineRun/PipelineRunDrawerRightContent.tsx
Outdated
Show resolved
Hide resolved
7b50016
to
3cec451
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…graph execution node drawer
3cec451
to
387ba0d
Compare
Closes: RHOAIENG-12089
Description
Added copy clipboard and copy button in the Pipeline run graph execution node drawer.
How Has This Been Tested?
Open a pipeline run execution and click on the node to open right drawer. Check the clipboard copy and popover text.
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
@yannnz