Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation and copy action for the Pod name in the Pipeline run graph execution node drawer #3312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented Oct 8, 2024

Closes: RHOAIENG-12089

Description

Added copy clipboard and copy button in the Pipeline run graph execution node drawer.

Screenshot 2024-10-08 at 9 22 00 PM Screenshot 2024-10-08 at 9 22 05 PM

How Has This Been Tested?

Open a pipeline run execution and click on the node to open right drawer. Check the clipboard copy and popover text.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main
    @yannnz

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (c4ae140) to head (387ba0d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
+ Coverage   84.84%   84.86%   +0.02%     
==========================================
  Files        1321     1321              
  Lines       29446    29447       +1     
  Branches     8037     8038       +1     
==========================================
+ Hits        24983    24990       +7     
+ Misses       4463     4457       -6     
Files with missing lines Coverage Δ
...ails/pipelineRun/PipelineRunDrawerRightContent.tsx 92.30% <100.00%> (+0.64%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ae140...387ba0d. Read the comment docs.

@yannnz
Copy link

yannnz commented Oct 9, 2024

UI looks good to me. Thanks. One thing I want to double check is if this pod name always displays in the UI even the pod has been expired?

@dpanshug
Copy link
Contributor Author

dpanshug commented Oct 9, 2024

One thing I want to double check is if this pod name always displays in the UI even the pod has been expired?

@yannnz, yes the pod name is still there.
Screenshot 2024-10-09 at 3 32 01 PM

@Gkrumbach07
Copy link
Member

Screenshot 2024-10-10 at 2 10 41 PM

This should not fully span horizontally.

@yannnz
Copy link

yannnz commented Oct 11, 2024

Screenshot 2024-10-10 at 2 10 41 PM

This should not fully span horizontally.

Thanks for pointing this out! Yeap it should keep the length with the content.

@dpanshug
Copy link
Contributor Author

@Gkrumbach07 @yannnz Fixed that width issue

Screenshot 2024-10-15 at 12 09 22 PM Screenshot 2024-10-15 at 12 09 34 PM

Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gkrumbach07. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants