Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount path in DS projects #3315

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Oct 9, 2024

https://issues.redhat.com/browse/RHOAIENG-426

Description

  • remove add storage button
  • Adding icon before storage name
  • Rename workbench storage to Cluster storages
  • Full mount path
  • show all button
Screenshot 2024-10-11 at 12 32 35 PM

How Has This Been Tested?

  • Go to Workbenches tab from project page
  • Click on one of the notebook/workbench row
  • Check whether mount path has full path
  • Check show less/all button

Test Impact

Added cypress test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1 pnaik1 force-pushed the rhoaineg-426 branch 2 times, most recently from 640c778 to 8562481 Compare October 9, 2024 12:16
@xianli123
Copy link

Thanks @pnaik1 @DaoDaoNoCode ! LGTM!

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (fee50c5) to head (d612c65).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...rojects/screens/detail/notebooks/ShowAllButton.tsx 72.72% 3 Missing ⚠️
...s/screens/detail/notebooks/NotebookStorageBars.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3315      +/-   ##
==========================================
- Coverage   84.88%   84.87%   -0.01%     
==========================================
  Files        1309     1309              
  Lines       29324    29296      -28     
  Branches     8000     7995       -5     
==========================================
- Hits        24891    24865      -26     
+ Misses       4433     4431       -2     
Files with missing lines Coverage Δ
...nd/src/components/InlineTruncatedClipboardCopy.tsx 50.00% <100.00%> (ø)
frontend/src/concepts/design/HeaderIcon.tsx 100.00% <100.00%> (ø)
frontend/src/pages/projects/notebook/utils.ts 32.31% <100.00%> (ø)
...rojects/screens/detail/notebooks/NotebookTable.tsx 100.00% <ø> (ø)
...ects/screens/detail/notebooks/NotebookTableRow.tsx 83.78% <ø> (-0.43%) ⬇️
...s/screens/detail/notebooks/NotebookStorageBars.tsx 81.25% <87.50%> (+19.71%) ⬆️
...rojects/screens/detail/notebooks/ShowAllButton.tsx 72.72% <72.72%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee50c5...d612c65. Read the comment docs.

@pnaik1 pnaik1 changed the title mount points in DS projects mount path in DS projects Oct 11, 2024
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 11, 2024
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dd41ed9 into opendatahub-io:main Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants