Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-1101] Cannot remove additional storage from the workbench configuration #3320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

[RHOAIENG-1101] Cannot remove additional storage from the workbench c…

a1db6ec
Select commit
Loading
Failed to load commit list.
Open

[RHOAIENG-1101] Cannot remove additional storage from the workbench configuration #3320

[RHOAIENG-1101] Cannot remove additional storage from the workbench c…
a1db6ec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 14, 2024 in 0s

84.63% (-0.16%) compared to 6ec1b1b

View this Pull Request on Codecov

84.63% (-0.16%) compared to 6ec1b1b

Details

Codecov Report

Attention: Patch coverage is 60.36036% with 44 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (6ec1b1b) to head (a1db6ec).

Files with missing lines Patch % Lines
...creens/spawner/storage/ClusterStorageEditModal.tsx 5.26% 18 Missing ⚠️
...ts/screens/spawner/storage/ClusterStorageTable.tsx 65.30% 17 Missing ⚠️
...eens/spawner/storage/ClusterStorageDetachModal.tsx 16.66% 5 Missing ⚠️
...c/pages/projects/screens/spawner/SpawnerFooter.tsx 76.47% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3320      +/-   ##
==========================================
- Coverage   84.79%   84.63%   -0.16%     
==========================================
  Files        1315     1318       +3     
  Lines       29491    29555      +64     
  Branches     8056     8070      +14     
==========================================
+ Hits        25006    25015       +9     
- Misses       4485     4540      +55     
Files with missing lines Coverage Δ
...src/pages/projects/screens/spawner/SpawnerPage.tsx 98.24% <100.00%> (+0.16%) ⬆️
...src/pages/projects/screens/spawner/spawnerUtils.ts 78.80% <100.00%> (-2.51%) ⬇️
...cts/screens/spawner/storage/StorageClassSelect.tsx 90.90% <100.00%> (-2.28%) ⬇️
...ages/projects/screens/spawner/storage/constants.ts 100.00% <100.00%> (ø)
...rc/pages/projects/screens/spawner/storage/utils.ts 96.00% <100.00%> (-0.43%) ⬇️
frontend/src/pages/projects/types.ts 100.00% <ø> (ø)
...c/pages/projects/screens/spawner/SpawnerFooter.tsx 83.46% <76.47%> (-1.23%) ⬇️
...eens/spawner/storage/ClusterStorageDetachModal.tsx 16.66% <16.66%> (ø)
...ts/screens/spawner/storage/ClusterStorageTable.tsx 65.30% <65.30%> (ø)
...creens/spawner/storage/ClusterStorageEditModal.tsx 5.26% <5.26%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec1b1b...a1db6ec. Read the comment docs.