Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alert text when disabling multi-serving platform or single-serving platform #3321

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Oct 10, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-4147

Description

Follow the description and change the text.

Screenshot 2024-10-10 at 11 22 53 AM Screenshot 2024-10-10 at 11 22 47 AM

How Has This Been Tested?

Go to the settings page, deselect single-serving platform or multi-serving platform. Check the alert text.

Test Impact

N/A, minor text change.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (a3c2b58) to head (3cae82c).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
+ Coverage   84.75%   84.76%   +0.01%     
==========================================
  Files        1309     1309              
  Lines       29316    29316              
  Branches     7981     7981              
==========================================
+ Hits        24846    24850       +4     
+ Misses       4470     4466       -4     
Files with missing lines Coverage Δ
...s/clusterSettings/ModelServingPlatformSettings.tsx 92.50% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3c2b58...3cae82c. Read the comment docs.

@pnaik1
Copy link
Contributor

pnaik1 commented Oct 11, 2024

/lgtm
works well

Screenshot 2024-10-11 at 3 59 02 PM

Screenshot 2024-10-11 at 3 58 51 PM

@Gkrumbach07
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9d766dc into opendatahub-io:main Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants